http://redmine.openspace3d.com/http://redmine.openspace3d.com/favicon.ico?16338348402014-09-30T13:54:10ZSCOL LanguageScol - Bug #489: Transparency parameter not taken into account in _CPbitmap24 (LIB2DOS24)http://redmine.openspace3d.com/issues/489?journal_id=8722014-09-30T13:54:10Zarkeonarkeon.work@gmail.com
<ul></ul><p>Did you check the function code ?</p> Scol - Bug #489: Transparency parameter not taken into account in _CPbitmap24 (LIB2DOS24)http://redmine.openspace3d.com/issues/489?journal_id=8732014-09-30T13:57:38Zarkeonarkeon.work@gmail.com
<ul></ul><p>Ho no this is not a bug.<br />_CPbitmap24 copy an objBitmap not an alphaBitmap</p>
<p>An alphaBitmap is composed of an objBitmap and an objBitmap8 for alpha channel.<br />so to copy an alphaBitmap you must get the separated components and copy the ObjBitmap and then the ObjBitmap8 to finally recreate an alphaBitmap.</p>
<p>or what you mean by "Transparency" is something else ?</p> Scol - Bug #489: Transparency parameter not taken into account in _CPbitmap24 (LIB2DOS24)http://redmine.openspace3d.com/issues/489?journal_id=8742014-09-30T14:17:09Ztonyafombaron@gmail.com
<ul></ul><p>arkeon wrote:</p>
<blockquote>
<p>Ho no this is not a bug.<br />_CPbitmap24 copy an objBitmap not an alphaBitmap</p>
<p>An alphaBitmap is composed of an objBitmap and an objBitmap8 for alpha channel.<br />so to copy an alphaBitmap you must get the separated components and copy the ObjBitmap and then the ObjBitmap8 to finally recreate an alphaBitmap.</p>
<p>or what you mean by "Transparency" is something else ?</p>
</blockquote>
<p>The transparency is the color transparency parameter which tells what should be copied or not from the source bitmap. So nothing to do with alphabitmaps, just with basic bitmaps (ObjBitmap)</p> Scol - Bug #489: Transparency parameter not taken into account in _CPbitmap24 (LIB2DOS24)http://redmine.openspace3d.com/issues/489?journal_id=8752014-09-30T14:19:08Ztonyafombaron@gmail.com
<ul><li><strong>Assignee</strong> set to <i>tony</i></li></ul> Scol - Bug #489: Transparency parameter not taken into account in _CPbitmap24 (LIB2DOS24)http://redmine.openspace3d.com/issues/489?journal_id=8762014-09-30T14:23:10Ztonyafombaron@gmail.com
<ul></ul><p>tony wrote:</p>
<blockquote>
<p>arkeon wrote:</p>
<blockquote>
<p>Ho no this is not a bug.<br />_CPbitmap24 copy an objBitmap not an alphaBitmap</p>
<p>An alphaBitmap is composed of an objBitmap and an objBitmap8 for alpha channel.<br />so to copy an alphaBitmap you must get the separated components and copy the ObjBitmap and then the ObjBitmap8 to finally recreate an alphaBitmap.</p>
<p>or what you mean by "Transparency" is something else ?</p>
</blockquote>
<p>The transparency is the color transparency parameter which tells what should be copied or not from the source bitmap. So nothing to do with alphabitmaps, just with basic bitmaps (ObjBitmap)</p>
</blockquote>
<p>I assigned this bug to myself. I'll have a look at it as soon as possible.</p> Scol - Bug #489: Transparency parameter not taken into account in _CPbitmap24 (LIB2DOS24)http://redmine.openspace3d.com/issues/489?journal_id=8772014-09-30T14:26:22Zarkeonarkeon.work@gmail.com
<ul></ul><p>srcColor = _COLOR_BGR_TO_I ((char)BS->bits[scx], (char)BS->bits[scx+1], (char)BS->bits[scx+2]);<br /> if ((couleur == NIL) || (srcColor != couleur))
{<br /> BD->bits [ dcx ] = BS->bits [ scx ] ;<br /> BD->bits [ dcx+1 ] = BS->bits [ scx+1 ] ;<br /> BD->bits [ dcx+2 ] = BS->bits [ scx+2 ] ;<br /> }</p>
<p>a small debug with _COLOR_BGR_TO_I comparison value should be easy.</p> Scol - Bug #489: Transparency parameter not taken into account in _CPbitmap24 (LIB2DOS24)http://redmine.openspace3d.com/issues/489?journal_id=8782014-09-30T14:48:38Ztonyafombaron@gmail.com
<ul></ul><p>arkeon wrote:</p>
<blockquote>
<p>srcColor = _COLOR_BGR_TO_I ((char)BS->bits[scx], (char)BS->bits[scx+1], (char)BS->bits[scx+2]);<br />if ((couleur == NIL) || (srcColor != couleur))
{<br />BD->bits [ dcx ] = BS->bits [ scx ] ;<br />BD->bits [ dcx+1 ] = BS->bits [ scx+1 ] ;<br />BD->bits [ dcx+2 ] = BS->bits [ scx+2 ] ;<br />}</p>
<p>a small debug with _COLOR_BGR_TO_I comparison value should be easy.</p>
</blockquote>
<p>Which file and which function ? please...</p>
<p>I had a very quick look (no real debugging) at the LIBOS2D dll and found functions that properly (or so it seemed) used the "couleur" (color) variable. But there must be some corruption somewhere.</p> Scol - Bug #489: Transparency parameter not taken into account in _CPbitmap24 (LIB2DOS24)http://redmine.openspace3d.com/issues/489?journal_id=8792014-09-30T14:50:59Zarkeonarkeon.work@gmail.com
<ul></ul><p>bitmap.c</p>
<p>function GRCopyBitmap line 3608</p> Scol - Bug #489: Transparency parameter not taken into account in _CPbitmap24 (LIB2DOS24)http://redmine.openspace3d.com/issues/489?journal_id=8802014-10-02T02:57:26Ztonyafombaron@gmail.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li></ul><p>Correction committed.<br />Transparency color was not taken into account if source and destination bitmaps had the same dimensions.</p> Scol - Bug #489: Transparency parameter not taken into account in _CPbitmap24 (LIB2DOS24)http://redmine.openspace3d.com/issues/489?journal_id=8812014-10-11T09:21:19Ztonyafombaron@gmail.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Estimated time</strong> set to <i>4.00 h</i></li></ul>